This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fixes for make clean (take 2)

From: Andreas Jaeger <aj at suse dot de>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Ulrich Drepper <drepper at redhat dot com>,Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Sat, 08 Jan 2005 17:49:23 +0100
Subject: Re: [PATCH] Fixes for make clean (take 2)
References: <m3sm5ibwe5.fsf@gromit.moeb><20050107124425.GB17169@sunsite.mff.cuni.cz><m3brc12veq.fsf@gromit.moeb><20050108163855.GD17169@sunsite.mff.cuni.cz>

Jakub Jelinek <jakub@redhat.com> writes:

> On Fri, Jan 07, 2005 at 02:58:21PM +0100, Andreas Jaeger wrote:
>> > This change is bad:
>> > make[2]: Entering directory
>> > `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/elf' Makefile:726: warning: overriding commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
>> > ../Rules:118: warning: ignoring old commands for target `/usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf/tst-pie1'
>> > mkdir /usr/src/build/502950-i686/BUILD/glibc-20050106T2203/build-i686-linux/elf
>> >
>> > I think putting tst-pie1.out and tst-pie1 into generated instead would cure
>> > this.
>> 
>> I'll revert my patch now,
>
> This seems to work for me:

But why is it necessary?  Why are we using both
tests: $(objpfx)some-test.out
and
tests += other-test

Only the later should be needed AFAIK,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

Follow-Ups:
- Re: [PATCH] Fixes for make clean (take 2)
  - From: Jakub Jelinek

References:
- Fixes for make clean
  - From: Andreas Jaeger
- Re: Fixes for make clean
  - From: Jakub Jelinek
- Re: Fixes for make clean
  - From: Andreas Jaeger
- [PATCH] Fixes for make clean (take 2)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]