This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add multiple inclusion guards to useldt.h

From: Roland McGrath <roland at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Ulrich Drepper <drepper at redhat dot com>,Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Sat, 25 Sep 2004 03:06:56 -0700
Subject: Re: [PATCH] Add multiple inclusion guards to useldt.h

> >From reading the code, I believe i686 --with-tls linuxthreads
> are now broken.

Ack!  You're right.  The report was about i586 being broken, and I tested
that and failed to go back and test the i686 build.  It's even worse than
you thought, though!  useldt.h gets included once before USE_TLS is set and
once after, changing how it defines things.  So plain multiple inclusion
protection would in fact break it.  I put in another tweak and now I think
both builds are ok again.


Thanks,
Roland

References:
- [PATCH] Add multiple inclusion guards to useldt.h
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]