This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] SH: Fixup pread/pwrite


Kaz Kojima wrote:

> The pread/write* stuff of sh-linux just includes the mips one and now
> the mips implementation uses more mips specific things like sgidefs.h
> which doesn't exist on SH.  The appended patch just copies them and
> removes the mips specific lines from them.

Yeah, but it's a copy.  I would rather like to see you using the other
files.  Yet another copy means more maintenance problems.  You can
define a macro in the SH files which prevents the MIPS header from being
included.  Or maybe this is even one of the rare situations where it is
OK to test for __mips__ or whatever the symbol gcc defines is since it
is indeed only for mips you want these headers.

-- 
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]