This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Avoid pthread_exit in librt.so.1


Hi!

Its a little hard to preach how costly pthread_exit (NULL); at the very end
of a thread main routine is compared to return NULL when glibc itself uses
it too...

2004-08-11  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/pthread/aio_misc.c (handle_fildes_io): Remove noreturn
	attribute.  Return NULL instead of calling pthread_exit at the end.

--- libc/sysdeps/pthread/aio_misc.c.jj	2004-05-26 16:05:31.000000000 +0200
+++ libc/sysdeps/pthread/aio_misc.c	2004-08-11 14:51:49.358696666 +0200
@@ -1,5 +1,6 @@
 /* Handle general operations.
-   Copyright (C) 1997,1998,1999,2000,2001,2003 Free Software Foundation, Inc.
+   Copyright (C) 1997, 1998, 1999, 2000, 2001, 2003, 2004
+   Free Software Foundation, Inc.
    This file is part of the GNU C Library.
    Contributed by Ulrich Drepper <drepper@cygnus.com>, 1997.
 
@@ -470,7 +471,6 @@ __aio_enqueue_request (aiocb_union *aioc
 
 
 static void *
-__attribute__ ((noreturn))
 handle_fildes_io (void *arg)
 {
   pthread_t self = pthread_self ();
@@ -676,7 +676,7 @@ handle_fildes_io (void *arg)
     }
   while (runp != NULL);
 
-  pthread_exit (NULL);
+  return NULL;
 }
 
 

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]