This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fix lvalue casts in elf/dl-load.c

The appended patch removes the with GCC 3.5 deprecated lvalue casts
and generates the same assembler code (tested with GCC 3.3
hammer-branch on AMD64).

Ok to commit?

Andreas

2004-02-21  Andreas Jaeger  <aj@suse.de>

	* elf/dl-load.c (_dl_map_object_from_fd): Fix casts used as lvalue.

============================================================
Index: elf/dl-load.c
--- elf/dl-load.c	9 Feb 2004 07:03:48 -0000	1.235
+++ elf/dl-load.c	21 Feb 2004 15:42:44 -0000
@@ -1228,7 +1228,7 @@ cannot allocate TLS data structures for 
       }
     else
       /* Adjust the PT_PHDR value by the runtime load address.  */
-      (ElfW(Addr)) l->l_phdr += l->l_addr;
+      l->l_phdr = (ElfW(Phdr) *) ((ElfW(Addr)) l->l_phdr + l->l_addr);
   }
 
 #ifdef USE_TLS
@@ -1254,7 +1254,7 @@ cannot allocate TLS data structures for 
 	}
     }
   else
-    (ElfW(Addr)) l->l_ld += l->l_addr;
+    l->l_ld = (ElfW(Dyn) *) ((ElfW(Addr)) l->l_ld + l->l_addr);
 
   l->l_entry += l->l_addr;
 

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]