This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Get rid of lvalue casts etc.

From: Andreas Jaeger <aj at suse dot de>
To: Andreas Schwab <schwab at suse dot de>
Cc: GNU libc hackers <libc-hacker at sources dot redhat dot com>
Date: Sat, 07 Feb 2004 17:27:05 +0100
Subject: Re: Get rid of lvalue casts etc.
References: <hod69c2q32.fsf@reger.suse.de> <je65f4t8uv.fsf@sykes.suse.de><m3ptcqj31j.fsf@gromit.moeb> <jefzdmvovy.fsf@sykes.suse.de>

Andreas Schwab <schwab@suse.de> writes:

> Andreas Jaeger <aj@suse.de> writes:
>
>> @@ -558,8 +564,13 @@ internal_ucs4le_loop_single (struct __gc
>>    *outptrp += 4;
>      ^^^^^^^^^^^^^^
>>  #else
>>    /* XXX unaligned */
>> -  *(*((uint32_t **) outptrp)++) = state->__value.__wch;
>> +  (*outptrp)[0] = state->__value.__wchb[0];
>> +  (*outptrp)[1] = state->__value.__wchb[1];
>> +  (*outptrp)[2] = state->__value.__wchb[2];
>> +  (*outptrp)[3] = state->__value.__wchb[3];
>> +
>>  #endif
>> +  *outptrp += 4;
>
> You forgot to delete the line above.

Thanks for the double-checking,

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

References:
- Re: Get rid of lvalue casts etc.
  - From: Andreas Jaeger
- Re: Get rid of lvalue casts etc.
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]