This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: build failure


On Fri, Jan 03, 2003 at 03:32:26PM -0800, Richard Henderson wrote:
> Anyone know what is supposed to be going on here, and why it doesn't
> seem to be working?
> 
> make[4]: Entering directory `/dorothy/rth/libc/libc/linuxthreads'
> Makefile:119: warning: overriding commands for target `/usr/lib/libpthread.so'
> ../o-iterator.mk:9: warning: ignoring old commands for target `/usr/lib/libpthread.so'
> gcc alloca_cutoff.c -c -std=gnu99 -O2 -Wall -Winline -Wstrict-prototypes -Wwrite-strings -g -mieee  -fpic    -I../include -I. -I/dorothy/rth/libc/build/linuxthreads -I.. -I../libio  -I/dorothy/rth/libc/build -I../linuxthreads/sysdeps/alpha/elf -I../sysdeps/alpha/elf -I../linuxthreads/sysdeps/unix/sysv/linux/alpha -I../linuxthreads/sysdeps/unix/sysv/linux -I../linuxthreads/sysdeps/pthread -I../sysdeps/pthread -I../linuxthreads/sysdeps/unix/sysv -I../linuxthreads/sysdeps/unix -I../linuxthreads/sysdeps/alpha -I../sysdeps/unix/sysv/linux/alpha -I../sysdeps/unix/sysv/linux -I../sysdeps/gnu -I../sysdeps/unix/common -I../sysdeps/unix/mman -I../sysdeps/unix/inet -I../sysdeps/unix/sysv -I../sysdeps/unix/alpha -I../sysdeps/unix -I../sysdeps/posix -I../sysdeps/alpha/alphaev67/fpu -I../sysdeps/alpha/alphaev6/fpu -I../sysdeps/alpha/alphaev67 -I../sysdeps/alpha/alphaev6 -I../sysdeps/alpha/alphaev5 -I../sysdeps/alpha/fpu -I../sysdeps/alpha -I../sysdeps/wordsize-64 -I../sysdeps/ieee754/flt-32 -I../sysdeps/ieee754/dbl-64 -I../sysdeps/ieee754 -I../sysdeps/generic/elf -I../sysdeps/generic   -D_LIBC_REENTRANT -include ../include/libc-symbols.h  -DPIC -DSHARED     -DNOT_IN_libc=1 -DIS_IN_rtld=1 -o /dorothy/rth/libc/build/linuxthreads/rtld-alloca_cutoff.os
> alloca_cutoff.c: In function `__libc_alloca_cutoff':
> alloca_cutoff.c:31: warning: implicit declaration of function `LIBC_THREAD_GETMEM'
> alloca_cutoff.c:31: error: `p_alloca_cutoff' undeclared (first use in this function)
> alloca_cutoff.c:31: error: (Each undeclared identifier is reported only once
> alloca_cutoff.c:31: error: for each function it appears in.)
> alloca_cutoff.c:31: warning: comparison between signed and unsigned
> make[4]: *** [/dorothy/rth/libc/build/linuxthreads/rtld-alloca_cutoff.os] Error 1
> make[4]: Leaving directory `/dorothy/rth/libc/libc/linuxthreads'
> make[3]: *** [/dorothy/rth/libc/build/linuxthreads/rtld-alloca_cutoff.os] Error 2
> make[3]: Leaving directory `/dorothy/rth/libc/libc/elf'
> make[2]: *** [/dorothy/rth/libc/build/elf/rtld-libc.a] Error 2
> make[2]: Leaving directory `/dorothy/rth/libc/libc/elf'
> make[1]: *** [elf/subdir_lib] Error 2
> make[1]: Leaving directory `/dorothy/rth/libc/libc'
> make: *** [all] Error 2

Does the following patch fix it?
It doesn't fail on IA-32/x86-64/IA-64, because
apparently rtld-alloca-cutoff.os is not compiled at all on those arches.
Wonder what object sucks it in.

2003-01-04  Jakub Jelinek  <jakub@redhat.com>

	* internals.h (LIBC_THREAD_GETMEM, LIBC_THREAD_SETMEM): Define
	even if NOT_IN_libc is defined.

--- libc/linuxthreads/internals.h.jj	2003-01-03 14:11:54.000000000 +0100
+++ libc/linuxthreads/internals.h	2003-01-04 02:10:56.000000000 +0100
@@ -43,15 +43,13 @@
 # define THREAD_SETMEM_NC(descr, member, value) descr->member = (value)
 #endif
 
-#ifndef NOT_IN_libc
-# ifdef FLOATING_STACKS
-#  define LIBC_THREAD_GETMEM(descr, member) THREAD_GETMEM (descr, member)
-#  define LIBC_THREAD_SETMEM(descr, member, value) \
+#if !defined NOT_IN_libc && defined FLOATING_STACKS
+# define LIBC_THREAD_GETMEM(descr, member) THREAD_GETMEM (descr, member)
+# define LIBC_THREAD_SETMEM(descr, member, value) \
   THREAD_SETMEM (descr, member, value)
-# else
-#  define LIBC_THREAD_GETMEM(descr, member) descr->member
-#  define LIBC_THREAD_SETMEM(descr, member, value) descr->member = (value)
-# endif
+#else
+# define LIBC_THREAD_GETMEM(descr, member) descr->member
+# define LIBC_THREAD_SETMEM(descr, member, value) descr->member = (value)
 #endif
 
 typedef void (*destr_function)(void *);


	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]