This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH] Fix linuxthreads and nptl builds

From: Jakub Jelinek <jakub at redhat dot com>
To: Ulrich Drepper <drepper at redhat dot com>, Roland McGrath <roland at redhat dot com>
Cc: Glibc hackers <libc-hacker at sources dot redhat dot com>
Date: Thu, 2 Jan 2003 13:51:06 +0100
Subject: [PATCH] Fix linuxthreads and nptl builds
Reply-to: Jakub Jelinek <jakub at redhat dot com>

Hi!

After __register_atfork has been made libc_hidden_*, the tree
is broken, since libpthread_nonshared.a contains undefined reference
to __GI___register_atfork (and this gets linked into librt.so too,
so librt is broken as well).
As pthread_atfork is not in the makefile part of any library routines
which would get special NOT_IN_libc IS_IN_something, it is compiled
as if it were part of libc.so, which is wrong.

2003-01-02  Jakub Jelinek  <jakub@redhat.com>

linuxthreads/
	* Makefile (CFLAGS-pthread_atfork.c): Add -DNOT_IN_libc.
nptl/
	* Makefile (CFLAGS-pthread_atfork.c): Add -DNOT_IN_libc.

--- libc/linuxthreads/Makefile.jj	2002-12-31 11:46:37.000000000 +0100
+++ libc/linuxthreads/Makefile	2003-01-02 15:11:19.000000000 +0100
@@ -1,4 +1,4 @@
-# Copyright (C) 1996-2001, 2002 Free Software Foundation, Inc.
+# Copyright (C) 1996-2002, 2003 Free Software Foundation, Inc.
 # This file is part of the GNU C Library.
 
 # The GNU C Library is free software; you can redistribute it and/or
@@ -54,6 +54,8 @@ libpthread-shared-only-routines = pt-all
 
 libpthread-nonshared = pthread_atfork
 
+CFLAGS-pthread_atfork.c = -DNOT_IN_libc
+
 nodelete-yes = -Wl,--enable-new-dtags,-z,nodelete
 initfirst-yes = -Wl,--enable-new-dtags,-z,initfirst
 LDFLAGS-pthread.so = $(nodelete-$(have-z-nodelete)) \
--- libc/nptl/Makefile.jj	2003-01-02 11:30:43.000000000 +0100
+++ libc/nptl/Makefile	2003-01-02 15:10:55.000000000 +0100
@@ -1,4 +1,4 @@
-# Copyright (C) 2002 Free Software Foundation, Inc.
+# Copyright (C) 2002, 2003 Free Software Foundation, Inc.
 # This file is part of the GNU C Library.
 
 # The GNU C Library is free software; you can redistribute it and/or
@@ -113,6 +113,8 @@ libpthread-shared-only-routines = pt-all
 
 libpthread-nonshared = pthread_atfork
 
+CFLAGS-pthread_atfork.c = -DNOT_IN_libc
+
 # Don't generate deps for calls with no sources.  See sysdeps/unix/Makefile.
 omit-deps = $(unix-syscalls:%=ptw-%)
 

	Jakub

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]