This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Two small fixes for s/390.


> I've added the first patch (minus the profil-counter.h change) plus
> parts of the second patch.
Thanks, that leaves the profil fix to worry about. In a previous mail you
had objections against a single header file that uses __s390x__ for 31/64
bit distinction. The only other way is to duplicate the profile-header.h
file to the s390-32/s390-64 subfolders.

> >      * sysdeps/s390/bits/string.h: Move/copy to ...
> >      * sysdeps/s390/s390-32/bits/string.h: ... here, remove s390x ifdefs.
> >      * sysdeps/s390/s390-64/bits/string.h: ... here, remove s390x ifdefs.
>
> This seems not to be right.  Correct me if I'm wrong but isn't it
> possible to run 31-bit applications on the 64-bit machines?  In this
> case the *installed* header bits/string.h should be universal.
Yes, I got the mail from Andreas where he points out that we need a single
header file for the bi-arch support 2 minutes after I send this patch.
The question left is how to distinguish between 31/64 bit. At the moment
__s390x__ is used. So far nobody came up with a better sugestion.

blue skies,
   Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: schwidefsky@de.ibm.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]