This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Put workaround in catclose too


Jakub Jelinek <jakub@redhat.com> writes:

> tcsh is broken and I'm afraid many other apps are too in that they don't
> bother checking whether catopen returned -1.

Actually, those applications are not broken.  It is far to bothersome
to write something like

   if (cat != (nl_catd) -1)
     printf (catgets (1, 1, 2, "foo"));
   else
     printf ("foo");

(and similarly for catclose).  Therefore the test is needed.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]