This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.
Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Andreas Jaeger <aj@suse.de> writes: |> Andreas Schwab <schwab@suse.de> writes: |> |> > This makes ldconfig working again. |> > |> > Andreas. |> > |> > 2001-06-13 Andreas Schwab <schwab@suse.de> |> > |> > * elf/ldconfig.c (search_dir): Fix check for regular file. |> > |> > --- elf/ldconfig.c.~1.21.~ Fri May 18 11:12:20 2001 |> >+++ elf/ldconfig.c Wed Jun 13 20:17:25 2001 |> > @@ -720,7 +720,7 @@ |> > add_single_dir (new_entry, 0); |> > continue; |> > } |> > - else if (!S_ISREG (stat_buf.st_mode) && !is_link) |> >+ else if (!S_ISREG (lstat_buf.st_mode) && !is_link) |> |> I prefer to switch the conditions: |> else if (!is_link && !S_ISREG (stat_buf.st_mode)) |> |> Please commit this, stat_buf is only defined if is_link is non-zero. I'm now committing my version. Andreas. -- Andreas Schwab "And now for something SuSE Labs completely different." Andreas.Schwab@suse.de SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |