This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Protect __STRING_INLINE in s390



>>
>> I got this warning on S390 and fixed it with the appended patch:
>> In file included from ../string/string.h:356,
>>                  from ../include/string.h:49,
>>                  from string-inlines.c:28:
>> ../sysdeps/s390/bits/string.h:37: warning: `__STRING_INLINE' redefined
>>
>> I'm committing the patch now,
>
>The patch is wrong. With this patch, glibc will not compile any
>longer on s390. You get a lot of errors about duplicate string
>symbols.

He is right. Although I don't understand it, how can an #ifndef protection
of __STRING_INLINE change anything ?

blue skies,
   Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: schwidefsky@de.ibm.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]