This is the mail archive of the libc-hacker@sources.redhat.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

string/Makefile broken


Uli,

your change from 2000-07-22 to string/Makefile is broken.

tst-svc reads from stdin - and your make rule just forgot about it
:-(.  Now the test waits for input from stdin - and doesn't get any.

Here's a patch.  I've committed it already,

Andreas

2000-07-24  Andreas Jaeger  <aj@suse.de>

	* string/Makefile ($(objpfx)tst-svc.out): Fix rule to read from
	input from stdin and setup environment.

============================================================
Index: string/Makefile
--- string/Makefile	2000/07/23 01:22:19	1.50
+++ string/Makefile	2000/07/24 13:37:50
@@ -62,7 +62,8 @@
 
 ifeq ($(cross-compiling),no)
 tests: $(objpfx)tst-svc.out
-$(objpfx)tst-svc.out: $(objpfx)tst-svc
-	$(built-program-cmd) $< > $@
+$(objpfx)tst-svc.out: tst-svc.input $(objpfx)tst-svc
+	GCONV_PATH=$(common-objpfx)iconvdata LC_ALL=C \
+	  $(built-program-cmd) < $(word 1,$^) > $@
 	-cmp tst-svc.expect $(objpfx)tst-svc.out
 endif

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.inka.de
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]