This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

PowerPC glibc CVS problems + patch



Hi,

I get the following warnings and errors when compiling glibc 2.2 CVS
on powerpc:

../sysdeps/powerpc/dl-start.S:68: warning: `/*' within comment
In file included from dynamic-link.h:21,
                 from dl-load.c:31:
../sysdeps/powerpc/dl-machine.h: In function `elf_machine_fixup_plt':
../sysdeps/powerpc/dl-machine.h:259: `map' undeclared (first use in this function)
../sysdeps/powerpc/dl-machine.h:259: (Each undeclared identifier is reported only once
../sysdeps/powerpc/dl-machine.h:259: for each function it appears in.)
../sysdeps/powerpc/dl-machine.h:259: `finaladdr' undeclared (first use in this function)
make[2]: *** [/abuild/aj/build-glibc-2.2/elf/dl-load.o] Error 1

Is the appended patch ok?  It still doesn't fix the finaladdr
parameter, I don't know which value it should get.

Thanks,
Andreas

2000-05-29  Andreas Jaeger  <aj@suse.de>

	* sysdeps/powerpc/dl-machine.h (elf_machine_fixup_plt): Fix
	parameter for call.

	* sysdeps/powerpc/dl-start.S: Close open comment.

============================================================
Index: sysdeps/powerpc/dl-machine.h
--- sysdeps/powerpc/dl-machine.h	2000/05/05 07:12:17	1.25
+++ sysdeps/powerpc/dl-machine.h	2000/05/29 07:24:43
@@ -256,7 +256,7 @@
 		       const Elf32_Rela *reloc,
 		       Elf32_Addr *reloc_addr, Elf64_Addr value)
 {
-  __elf_machine_fixup_plt (map, reloc, reloc_addr, finaladdr);
+  __elf_machine_fixup_plt (l, reloc, reloc_addr, finaladdr);
   return value;
 }
 
============================================================
Index: sysdeps/powerpc/dl-start.S
--- sysdeps/powerpc/dl-start.S	2000/05/04 23:12:19	1.4
+++ sysdeps/powerpc/dl-start.S	2000/05/29 07:24:43
@@ -56,7 +56,7 @@
 	lwz	r29,_dl_argc@got(r31)
 	lwz	r27,_dl_argv@got(r31)
 
-/* Call _dl_init (_dl_loaded, _dl_argc, _dl_argv, _dl_argv+_dl_argc+1)
+/* Call _dl_init (_dl_loaded, _dl_argc, _dl_argv, _dl_argv+_dl_argc+1).  */
 	lwz	r3,0(r28)
 	lwz	r4,0(r29)
 	lwz	r5,0(r27)

-- 
 Andreas Jaeger
  SuSE Labs aj@suse.de
   private aj@arthur.rhein-neckar.de

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]