This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.
Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
>>>>> Ralf Baechle writes: Ralf> On Fri, May 26, 2000 at 05:07:37PM +0200, Andreas Jaeger wrote: >> Here's a patch to unify the different pread64/pwrite64 versions. >> >> There're other functions that could use the same treatment. >> >> Uli, is it ok to commit this? Ralf> Please undo the MIPS part of the change. 32-bit MIPS passed the 64-bit Ralf> offset not as the 5th but 6th argument. Praise the ABI ... Are you sure that it was correct before? We had (for pread.c): # if defined(__MIPSEB__) result = INLINE_SYSCALL (pread, 6, fd, buf, count, 0, 0, offset); # elif defined(__MIPSEL__) result = INLINE_SYSCALL (pread, 6, fd, buf, count, 0, offset, 0); # endif According to your comment this should be for both endianesses: result = INLINE_SYSCALL (pread, 6, fd, buf, count, 0, offset, 0) Is this correct? I'll make the changes for pread{64},pwrite{64},{f}truncate64 in the next days. Thanks for double checking! Andreas -- Andreas Jaeger SuSE Labs aj@suse.de private aj@arthur.rhein-neckar.de
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |