This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] libio fixes for glibc 2.1.90


Jakub Jelinek <jakub@redhat.com> writes:

> The following patch makes groff and a bunch of other programs work with
> glibc 2.1.90.
> The issue is that libstdc++'s libio declares its own stdin/stdout/stderr
> which lacks the _wide_data stuff and several pieces of glibc just trustfully
> dereference _wide_data member of _IO_FILE.
> IMHO even if libstdc++'s libio is changed so that for *-libc6.2-* libstdc++
> (or always) puts the _wide_data stuff in, we need to maintain backward
> compatibility with older libstdc++'s.

Backward compatibility, yes.  But your patch is adding code to the
wide char functions.  This is not necessary since no program can/must
use the wide character functions when the using an old libio.

The changes must be reduced to the absolute minimum and not simply
cover every place where a problem could be.

Also, the changes should somehow be marked as only necessary if
compatibility with 2.0/2.1 is required.  For IA-64, for instance,
it'll not be necessary.

-- 
---------------.      drepper at gnu.org  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]