This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Kill warnings in gconv.h


On Thu, May 04, 2000 at 06:43:43PM +0200, Andreas Jaeger wrote:
> >>>>> Jakub Jelinek writes:
> 
>  > Hi!
>  > Including gconv.h when gcc -pedantic spits out unneeded warnings.
> 
> IMHO -pedantic makes only sense if you also specify -ansi - and since
> gconv.h is not part of ISO C, we don't really need to care.

gconv.h is included indirectly from <stdio.h>, and even if you use -pedantic
-ansi, you'll get the warning. ANSI C89 does not allow zero-sized arrays.
There is a bunch of projects which use -pedantic at the moment, e.g.
XFree86 4.0 or from yesterday gcc as well and IMHO the __extension__ will
not hurt and will kill a warning on about every file in projects using
-pedantic.

Here is another -pedantic patch (again, included from stdio.h):

2000-05-04  Jakub Jelinek  <jakub@redhat.com>

	* sysdeps/generic/bits/confname.h (_SC* enum): Avoid comma at the
	end of enum.

--- libc/sysdeps/generic/bits/confname.h.jj	Thu May  4 20:33:16 2000
+++ libc/sysdeps/generic/bits/confname.h	Thu May  4 20:34:12 2000
@@ -420,7 +420,7 @@ enum
 #define _SC_PBS_MESSAGE			_SC_PBS_MESSAGE
     _SC_PBS_TRACK,
 #define _SC_PBS_TRACK			_SC_PBS_TRACK
-    _SC_SYMLOOP,
+    _SC_SYMLOOP
 #define _SC_SYMLOOP			_SC_SYMLOOP
   };
 


	Jakub

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]