This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.

Note that libc-hacker is a closed list. You may look at the archives of this list, but subscription and posting are not open.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Why this strange change?

Hi, Ulrich,

Your change

1999-06-17  Ulrich Drepper  <drepper@cygnus.com>

        * nss/getXXbyYY_r.c: Return error code not -1. 
        * nss/getXXent_r.c: Likewise.

breaks glibc and Linux very badly. Any codes like

	if (getXXbyYY_r (......) < 0)

now don't work anymore since now getXXbyYY_r () returns errno which is
a positive number. Did you mean to return NAGATIVE of the error code?
Could you please double check all of your similar changes and fix them?

BTW, even if you can change all of

	if (getXXbyYY_r (......) < 0)

in glibc, how do you change all the user codes? I am not sure it is a
good idea to make a change like that. You changed ABI in fact.

Thanks.

-- 
H.J. Lu (hjl@gnu.org)
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]