This is the mail archive of the libc-hacker@sourceware.cygnus.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: make install problem


On Mon, 1 Jun 1998 10:25:00 +0200 (CEST), Andreas Jaeger wrote:
>
>Hi Zack,
>
>installing with make install install_root=/tmp/test-install I noticed
>that libc_pic.a gets installed:
>/bin/install -c -m 644 /usr/glibc/src/build-2.1/libc_pic.a /tmp/test-install/u
>sr/glibc/glibc-2.1/lib/libc_pic.a
>
>I do think that's wrong.  I'm also missing the call of
>test-installation.pl at the end of the install process.

I think it was being installed before, but it does seem a bit
pointless.

Patch below addresses both issues.

zw

1998-06-01 09:03:37  Zack Weinberg  <zack@rabi.phys.columbia.edu>

	* Make-top (install): Don't install libc_pic.a.
	(libc-final-install): Run test-installation.pl if possible.

============================================================
Index: Make-top
--- Make-top	Sat, 30 May 1998 15:54:11 -0400 zack  Z.7
+++ Make-top	Mon, 01 Jun 1998 09:02:02 -0400 zack  Z.7(w)
@@ -164,8 +164,7 @@
 
 ifeq ($(build-shared),yes)
 
-install: $(inst_libdir)/libc.so $(inst_libdir)/libc_pic.a \
-		libc-final-install
+install: $(inst_libdir)/libc.so libc-final-install
 
 # With side effects...
 $(inst_slibdir)/lib$(libc-name)-$(version).so: $(objpfx)libc.so $(+force)
@@ -202,9 +201,6 @@
 	) > $@.new
 	mv -f $@.new $@
 
-$(inst_libdir)/libc_pic.a: $(common-objpfx)libc_pic.a
-	$(do-install)
-
 libc-final-install:	$(inst_slibdir)/ld-$(version).so \
 			$(inst_slibdir)/lib$(libc-name)-$(version).so \
 			$(inst_slibdir)/libdl-$(version).so \
@@ -213,6 +209,13 @@
 		$(inst_slibdir)/$(rtld-installed-name)T \
 		$(inst_slibdir)/lib$(libc-name).so$(libc.so-version)T \
 		$(inst_slibdir)libdl.so$(libdl.so-version)T
+ifneq ($(PERL),no)
+ifeq ($(prefix),/usr)
+ifeq ($(install_root),)
+	$(PERL) scripts/test-installation.pl $(common-objpfx)soversions.mk
+endif
+endif
+endif
 
 $(common-objpfx)unT: scripts/unT.c
 	$(BUILD_CC) -static -O2 -g -Wall $< -o $@


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]