This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 01/17] y2038: compat: Move common compat types to asm-generic/compat.h
- From: Christoph Hellwig <hch at infradead dot org>
- To: Arnd Bergmann <arnd at arndb dot de>
- Cc: tglx at linutronix dot de, y2038 at lists dot linaro dot org, hch at infradead dot org, linux-api at vger dot kernel dot org, linux-arch at vger dot kernel dot org, libc-alpha at sourceware dot org, albert dot aribaud at 3adev dot fr, netdev at vger dot kernel dot org, viro at zeniv dot linux dot org dot uk, peterz at infradead dot org, dvhart at infradead dot org, ebiederm at xmission dot com, linux at dominikbrodowski dot net
- Date: Tue, 17 Jul 2018 05:49:25 -0700
- Subject: Re: [PATCH v2 01/17] y2038: compat: Move common compat types to asm-generic/compat.h
- References: <20180716161103.16239-1-arnd@arndb.de> <20180716161103.16239-2-arnd@arndb.de>
On Mon, Jul 16, 2018 at 06:10:47PM +0200, Arnd Bergmann wrote:
> While converting compat system call handlers to work on 32-bit
> architectures, I found a number of types used in those handlers
> that are identical between all architectures.
>
> Let's move all the identical ones into asm-generic/compat.h to avoid
> having to add even more identical definitions of those types.
>
> For unknown reasons, mips defines __compat_gid32_t, __compat_uid32_t
> and compat_caddr_t as signed, while all others have them unsigned.
> This seems to be a mistake, but I'm leaving it alone here. The other
> types all differ by size or alignment on at least on architecture.
>
> compat_aio_context_t is currently defined in linux/compat.h but
> also needed for compat_sys_io_getevents(), so let's move it into
> the same place.
>
> While we still have not decided whether the 32-bit time handling
> will always use the compat syscalls, or in which form, I think this
> is a useful cleanup that we can merge regardless.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>