This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use correct includes in benchtests


Florian Weimer wrote:

> I think this broken --enable-static-pie builds for some reason:
>
> In file included from bench-timing-type.c:19:0:
> bench-timing.h:19:0: error: "attribute_hidden" redefined [-Werror]
>   #define attribute_hidden
> In file included from <command-line>:0:0:
> ./../include/libc-symbols.h:361:0: note: this is the location of the 
> previous definition
>  # define attribute_hidden __attribute__ ((visibility ("hidden")))
>
> Any suggestions how to fix this?  Just stick an #undef attribute_hidden 
> in front of it?

Hmm that looks like a preincluded file, which is done just before we
define _ISOMAC... So I wonder whether it would be better to fix
Makeconfig to pre-includes after the CPPFLAGS rather than in the
middle of it?

 CPPFLAGS = $(config-extra-cppflags) $(CPPUNDEFS) $(CPPFLAGS-config) \
           $($(subdir)-CPPFLAGS) \
           $(+includes) $(defines) $(module-cppflags) \
           -include $(..)include/libc-symbols.h $(sysdep-CPPFLAGS) \
           $(CPPFLAGS-$(suffix $@)) \
           $(foreach lib,$(libof-$(basename $(@F))) \
                         $(libof-$(<F)) $(libof-$(@F)),$(CPPFLAGS-$(lib))) \

Wilco

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]