This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use correct includes in benchtests

From: Zack Weinberg <zackw at panix dot com>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
Date: Thu, 15 Mar 2018 10:42:18 -0400
Subject: Re: [PATCH] Use correct includes in benchtests
References: <DB6PR0801MB20534A15313278C542ACB40983D00@DB6PR0801MB2053.eurprd08.prod.outlook.com>

On Thu, Mar 15, 2018 at 10:29 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
> Currently the benchtests are run with internal GLIBC headers, which is incorrect.
> Defining _ISOMAC in the makefile ensures the internal headers are bypassed.
> Fix all tests which were relying on internal defines or includes.
...
> -CPPFLAGS-nonlib += -DDURATION=$(BENCH_DURATION)
> +CPPFLAGS-nonlib += -DDURATION=$(BENCH_DURATION) -D_ISOMAC

Is there a reason you can't change `lib := nonlib` to `lib :=
testsuite` in the invocation of libof-iterator.mk, instead?  Several
other places in the Makefile would need to be changed, but using the
testsuite module is abstractly more appropriate and might have other
desirable effects in the future (e.g. not including libc-symbols.h at
all).

zw

Follow-Ups:
- Re: [PATCH] Use correct includes in benchtests
  - From: Siddhesh Poyarekar

References:
- [PATCH] Use correct includes in benchtests
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]