This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 1/3] Cleanup __ieee754_sqrt(f/l)

From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
Date: Wed, 14 Mar 2018 17:34:22 +0000
Subject: Re: [PATCH v3 1/3] Cleanup __ieee754_sqrt(f/l)
Nodisclaimer: True
References: <DB6PR0801MB2053DCCDB0C7A490A861AE8783D20@DB6PR0801MB2053.eurprd08.prod.outlook.com>,<alpine.DEB.2.20.1803132232570.22082@digraph.polyomino.org.uk> <DB6PR0801MB2053D6F27EA932320705462B83D10@DB6PR0801MB2053.eurprd08.prod.outlook.com>,<alpine.DEB.2.20.1803141643210.26962@digraph.polyomino.org.uk>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

Joseph Myers wrote:

> If the benchmarks are compiled without _ISOMAC being defined, that's the 
> bug that should be fixed.  Changing them to use math/math.h is definitely 
> wrong.

Unfortunately it's not possible to define _ISOMAC since many tests actually require
internal headers, for example the string benchmarks often need inhibit_loop_to_libcall
which is defined only if _ISOMAC is not defined.

Defining _ISOMAC just for the math tests seems to work though, that looks like a
reasonable workaround for now.

Wilco

Follow-Ups:
- Re: [PATCH v3 1/3] Cleanup __ieee754_sqrt(f/l)
  - From: Joseph Myers

References:
- [PATCH v3 1/3] Cleanup __ieee754_sqrt(f/l)
  - From: Wilco Dijkstra
- Re: [PATCH v3 1/3] Cleanup __ieee754_sqrt(f/l)
  - From: Joseph Myers
- Re: [PATCH v3 1/3] Cleanup __ieee754_sqrt(f/l)
  - From: Wilco Dijkstra
- Re: [PATCH v3 1/3] Cleanup __ieee754_sqrt(f/l)
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]