This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/6] Remove slow paths from sin/cos
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: nd <nd at arm dot com>
- Date: Fri, 9 Mar 2018 21:32:29 +0530
- Subject: Re: [PATCH 6/6] Remove slow paths from sin/cos
- Authentication-results: sourceware.org; auth=none
- References: <DB6PR0801MB20536DE50F24E83BB7B6182383DE0@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On Friday 09 March 2018 09:22 PM, Wilco Dijkstra wrote:
> Restructure the sincos implementation - rather than rely on odd partial inlining
> of preprocessed portions from sin and cos, explicitly write out the cases.
The intention of keeping the inlines was to avoid duplicating code
across files. With this change one now must remember to make changes in
both files at all times, increasing the chances of an error. Do you see
any gain from duplicating code?
Siddhesh