This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[COMMITTED 3/3] benchtests: Don't benchmark 0 length calls for strncmp
- From: Siddhesh Poyarekar <siddhesh at sourceware dot org>
- To: libc-alpha at sourceware dot org
- Date: Tue, 6 Mar 2018 19:11:38 +0530
- Subject: [COMMITTED 3/3] benchtests: Don't benchmark 0 length calls for strncmp
- Authentication-results: sourceware.org; auth=none
- References: <20180306134138.27724-1-siddhesh@sourceware.org>
The 0 length strncmp is interesting for correctness but not for
performance.
* benchtests/bench-strncmp.c (test_main): Remove 0 length tests.
(do_test_limit): Likewise.
---
benchtests/bench-strncmp.c | 24 ------------------------
1 file changed, 24 deletions(-)
diff --git a/benchtests/bench-strncmp.c b/benchtests/bench-strncmp.c
index 4354d708fb..97dc39069d 100644
--- a/benchtests/bench-strncmp.c
+++ b/benchtests/bench-strncmp.c
@@ -137,29 +137,6 @@ do_test_limit (json_ctx_t *json_ctx, size_t align1, size_t align2, size_t len,
size_t i, align_n;
CHAR *s1, *s2;
- if (n == 0)
- {
- json_element_object_begin (json_ctx);
- json_attr_uint (json_ctx, "strlen", (double) len);
- json_attr_uint (json_ctx, "len", (double) n);
- json_attr_uint (json_ctx, "align1", (double) 0);
- json_attr_uint (json_ctx, "align2", (double) 0);
- json_array_begin (json_ctx, "timings");
-
- FOR_EACH_IMPL (impl, 0)
- {
- realloc_bufs ();
- s1 = (CHAR *) (buf1 + page_size);
- s2 = (CHAR *) (buf2 + page_size);
- do_one_test (json_ctx, impl, s1, s2, n, 0);
- }
-
- json_array_end (json_ctx);
- json_element_object_end (json_ctx);
-
- return;
- }
-
align1 &= 15;
align2 &= 15;
align_n = (page_size - n * CHARBYTES) & 15;
@@ -315,7 +292,6 @@ test_main (void)
do_test (&json_ctx, 2 * i, i, 8 << i, 16 << i, 255, 1);
}
- do_test_limit (&json_ctx, 0, 0, 0, 0, 127, 0);
do_test_limit (&json_ctx, 4, 0, 21, 20, 127, 0);
do_test_limit (&json_ctx, 0, 4, 21, 20, 127, 0);
do_test_limit (&json_ctx, 8, 0, 25, 24, 127, 0);
--
2.14.3