This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/7] Consolidate alphasort{64} and versionsort{64} implementation



On 02/03/2018 17:33, Joseph Myers wrote:
> On Fri, 2 Mar 2018, Adhemerval Zanella wrote:
> 
>> Also on Linux the compat symbol for old non-LFS dirent64 definition
>> requires a platform-specific scandir64.c.  For powerpc32 and sparcv9
>> it requires to add specific arch-implementation to override the
>> generic Linux one because neither ABI exports an compat symbol for
>> non-LFS alphasort64 and versionsort64 variant.  Considering both
>> architectures do export other compat symbols for other dirent.h
>> functions I think this is a bug (I need confirmation).
> 
> If it is a bug, it's also not one that can be fixed (in that there would 
> be existing binaries expecting both meanings of that symbol at its single 
> existing version, with binaries expecting the new meaning probably much 
> more common than those expecting the original meaning of that symbol at 
> that version).
> 

Right, so I think this initial approach of keep current symbol versioning
is the correct one.  I will add your remark in commit message.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]