This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add include guards to bits/sigaction.h
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Samuel Thibault <samuel dot thibault at ens-lyon dot org>
- Cc: <libc-alpha at sourceware dot org>, Zack Weinberg <zackw at panix dot com>
- Date: Mon, 5 Mar 2018 21:43:06 +0000
- Subject: Re: [PATCH] Add include guards to bits/sigaction.h
- Authentication-results: sourceware.org; auth=none
- References: <20180305011947.27062-1-samuel.thibault@ens-lyon.org>
On Mon, 5 Mar 2018, Samuel Thibault wrote:
> +#ifndef __struct_sigaction_defined
> +#define __struct_sigaction_defined 1
I don't think this is an appropriate guard for a header that defines more
than just struct sigaction; I think you should use _BITS_SIGACTION_H in
this case.
--
Joseph S. Myers
joseph@codesourcery.com