This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v8 1/8] nptl: Add C11 threads thrd_* functions
On Fri, 09 Feb 2018, Adhemerval Zanella wrote:
>On 08/02/2018 11:49, Gabriel F. T. Gomes wrote:
>> On Fri, 02 Feb 2018, Adhemerval Zanella wrote:
>>
>>> -/* We do not support C11 <threads.h>. */
>>> -#define __STDC_NO_THREADS__ 1
>>
>> I don't know if that actually matters, but should you wait until the other
>> patches in this series (at least patch 2) are in before removing this
>> definition?
>
>I do not have a strong opinion about when to remove __STDC_NO_THREADS__, since
>my idea is first get all patches reviewed and acked before actually commit then.
Fair enough.
I also reviewed the other patches in this set, and I don't have further
comments other than the cosmetic bit below.
(Since I'm definitely *not* an expert at threads, I only checked against
the standard and it looks good to me. So, please read this review as one
from a novice)
On patch 4:
>+/* Destroy condition variable pointed by __cond and free all of its
>+ resources. */
>+extern void cnd_destroy (cnd_t *__COND);
~~~~~~
Only here, the parameter name is in uppercase (and the comment in
lowercase). Any special reason to do so?