This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 2/5] Remove getc and putc macros from the public stdio.h.
On Mon, Feb 5, 2018 at 7:01 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Mon, 5 Feb 2018, Zack Weinberg wrote:
>> diff --git a/NEWS b/NEWS
>> index 3ac57eca4ee..eceab2b2be2 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -15,6 +15,13 @@ Deprecated and removed features, and other changes affecting compatibility:
>>
>> [Add deprecations, removals and changes affecting compatibility here]
>>
>> + * The stdio.h functions 'getc' and 'putc' are no longer defined as macros.
>> + This was never required by the C standard, and the macros just expanded
>> + to call alternative names for the same functions. If you hoped getc and
>> + putc would provide performance improvements over fgetc and fputc, instead
>> + investigate using (f)getc_unlocked and (f)putc_unlocked, and, if
>> + necessary, flockfile and funlockfile.
>
> The "[Add deprecations, removals and changes affecting compatibility
> here]" placeholder should be removed by this patch, as the first one to
> put something in this section for 2.28.
Doh! That was a merge botch on my end.
> The patch is OK with that change.
I have made that change and pushed patches 1 and 2 of this series.
Also, the full patchset is now available as git branch
'zack/no-libio-h' if anyone wants to experiment with it.
zw