Re: [PATCH] libnsl: Turn remaining symbols into compat symbols [BZ #22701]

[Carlos O'Donell <carlos at redhat dot com>]

On 01/29/2018 06:12 PM, Joseph Myers wrote:
> On Mon, 29 Jan 2018, H.J. Lu wrote:
> 
>> On Mon, Jan 29, 2018 at 5:01 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>>> I think this introduces test failures in the case where there is an
>>> installed libnss_nis but you're not using --enable-obsolete-nsl, if
>>> /etc/nsswitch.conf has "passwd: compat".
>>>
>>> FAIL: nss/bug17079
>>> FAIL: nss/tst-nss-getpwent
>>>
>>> The output of make check for those tests shows (seen on Ubuntu 16.04):
>>> "relocation error: /lib/x86_64-linux-gnu/libnss_nis.so.2: symbol
>>> _nsl_default_nss version GLIBC_PRIVATE not defined in file libnsl.so.1
>>> with link time reference", for both those tests.
>>
>> This is:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=22530
>>
>> Should I reopen it?
> 
> No, I think this is a different issue involving a different NSS module.  
> I suppose the present issue might be resolved by restoring the 
> _nsl_default_nss symbol, for example.
 
This is clearly a bug in the test framework. We should mark it XFAIL for
2.27 and fix this in 2.28.

DJ has complete patches to add "in mount namespace" testing which allows us
to completely isolate NSS module tests. The work is complete and pending
some review by me before we post these publicly. DJ has even run the entire
testsuite through the installed-tree-equivalent testing that is provided
by testing in the mount namespace, though it requires your system be configured
to allow user mount namespaces. DJ can comment more here if he wishes.

I want to avoid anyone doing any work here because in 2.28 I'd expect
we'll have converted these tests to use this work (part of the support/
library), and avoid the host configuration issues that have plagued our
testing.

-- 
Cheers,
Carlos.