On Thu, 25 Jan 2018, Palmer Dabbelt wrote:
This uses '.section .init_array,"aw"', while pt-crti.S contains
'.section .init_array,"a",%init_array'. I think we should include the
'%init_array' section type as well. Additionally, I'm not sure about
I think you should follow pt-crti.S exactly - using "a" not "aw" and using
%init_array. You also need to remove the #include of <sys/asm.h>, which
is an architecture-specific header not available on most architectures.
OK with those changes.
the % vs @ distinction -- the gas documentation suggests that only ARM
uses '%', so maybe this generic directory should use '@' instead? FWIW,
the RISC-V assembler appears to accept '%init_array' and '@init_array'.
% is valid everywhere. @ is valid everywhere except platforms, such as
ARM, that use @ as a comment character that can start comments in the
middle of a line. So in such an architecture-independent file, % is
appropriate.