This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH 1/2] Linux/x86: Update cancel_jmp_buf to match __jmp_buf_tag [BZ #22563]


> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Sunday, January 21, 2018 17:27
> To: Florian Weimer <fweimer@redhat.com>; Andreas Schwab
> <schwab@suse.de>; GNU C Library <libc-alpha@sourceware.org>;
> Senkevich, Andrew <andrew.senkevich@intel.com>
> Subject: Re: [PATCH 1/2] Linux/x86: Update cancel_jmp_buf to match
> __jmp_buf_tag [BZ #22563]
> 
> On Sun, Jan 21, 2018 at 8:15 AM, Aurelien Jarno <aurelien@aurel32.net>
> wrote:
> > On 2018-01-09 11:47, Florian Weimer wrote:
> >> On 12/18/2017 03:48 PM, H.J. Lu wrote:
> >> > On Mon, Dec 18, 2017 at 6:44 AM, Andreas Schwab <schwab@suse.de>
> wrote:
> >> > > On Dez 18 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote:
> >> > >
> >> > > > This patch adds bits/types/__cancel_jmp_buf_tag.h to define
> >> > > > struct __cancel_jmp_buf_tag so that Linux/x86 can add
> >> > > > saved_mask to cancel_jmp_buf.
> >> > >
> >> > > Isn't that an ABI change?
> >> > >
> >> >
> >> > Yes, this change is exposed to application via <phread.h>.  The
> >> > backward binary compatibility is provided by
> >> >
> >> > https://sourceware.org/ml/libc-alpha/2017-12/msg00208.html
> >>
> >> This doesn't seem to work:
> >>
> >> <https://sourceware.org/ml/libc-alpha/2018-01/msg00178.html>
> >>
> >> I have no idea what is going on, but if we can't find the root cause,
> >> I think we should revert all the setjmp changes.
> >
> > Commit f81ddabffd also breaks software like vlc or amarok, they crash
> > with a segmentation fault during startup. Reverting the commit
> > f81ddabffd fixes the issue.
> >
> > See debian bugs #887078 and #887886.
> >
> 
> Hi Andrew,
> 
> This may be easier to track.  Please investigate.

Looks like that.
I will have ability to investigate it during tomorrow.


--
Andrew

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]