This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] nptl: Add PTHREAD_MIN_STACK C++ throw test [BZ #22636]

From: Florian Weimer <fweimer at redhat dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org
Date: Mon, 15 Jan 2018 15:29:10 +0100
Subject: Re: [PATCH] nptl: Add PTHREAD_MIN_STACK C++ throw test [BZ #22636]
Authentication-results: sourceware.org; auth=none
References: <20180112092223.AB07C41610759@oldenburg.str.redhat.com> <2577d8f9-5ed9-769e-e0f8-63208810cb71@redhat.com> <0F3F73B6-0AFA-46D0-BCE6-BDC4D3F26C7A@linaro.org>

On 01/15/2018 03:26 PM, Adhemerval Zanella wrote:

Il giorno 15 gen 2018, alle ore 11:46, Florian Weimer <fweimer@redhat.com> ha scritto:

On 01/12/2018 10:22 AM, Florian Weimer wrote:
+/* Test that throwing C++ exceptions works with the minimum stack size.


Any comments on this new test?

<https://sourceware.org/ml/libc-alpha/2018-01/msg00438.html>


LGTM, just curious why you need the noclone and weak alias on do_throw_exception.

It's the most reliable way known to me to write a function-levelcompiler barrier.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>


Thanks,
Florian

References:
- [PATCH] nptl: Add PTHREAD_MIN_STACK C++ throw test [BZ #22636]
  - From: Florian Weimer
- Re: [PATCH] nptl: Add PTHREAD_MIN_STACK C++ throw test [BZ #22636]
  - From: Florian Weimer
- Re: [PATCH] nptl: Add PTHREAD_MIN_STACK C++ throw test [BZ #22636]
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]