Re: [PATCHv2] powerpc: Fix syscalls during early process initialization [BZ #22685]

[Florian Weimer <fweimer at redhat dot com>]

On 01/12/2018 05:40 PM, Tulio Magno Quites Machado Filho wrote:
> Florian Weimer <fweimer@redhat.com> writes:
>
> > On 01/12/2018 05:07 PM, Tulio Magno Quites Machado Filho wrote:
> > > +/* __access_noerrno is used during process initialization in elf/dl-tunables.c
> > > +   before the TCB is initialized, prohibiting the usage of
> > > +   ABORT_TRANSACTION.  */
> > > +#undef ABORT_TRANSACTION
> > > +#define ABORT_TRANSACTION
> > > +
> > > +#include "sysdeps/unix/sysv/linux/not-errno.h"
> >
> > This #define isn't properly scoped, so I really don't like this approach
> > for a header file.
>
> Do you think that checking for TUNABLES_INTERNAL would be enough?

I'm not sure what you mean.

If you move the current definition of ABORT_TRANSACTION to 
ABORT_TRANSACTION_IMPL, you could perhaps do

#undef ABORT_TRANSACTION
#define ABORT_TRANSACTION

#include "sysdeps/unix/sysv/linux/not-errno.h"

#undef ABORT_TRANSACTION
#define ABORT_TRANSACTION ABORT_TRANSACTION_IMPL

(with comments, obviously).

Thanks,
Florian