This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v11 3/5] Abbreviated alternative month names (%Ob) also added (bug 10871).
11.01.2018 20:14 Carlos O'Donell <carlos@redhat.com> wrote:
>
>
> On 01/11/2018 11:04 AM, Rafal Luzynski wrote:
> > [...]
> > So, do you guys want me to use a different naming pattern already?
>
> Please keep the code as-is. Thank you for explaining the situation, it
> clarifies
> the point. The code is OK to go in as-is.
OK
> >> OK with the test case changes to write UTF-8 directly in the test case
> >> string.
> >
> > A question about it below.
> >
> >> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> >
> > I am going to publish another set of patches, mostly due to the changes
> > in ChangeLog and commit messages. Does this Reviewed-by tag apply to the
> > new patches as well?
>
> Yes, it applies also to the new patches, as long as no substantive changes
> are made to the code. I don't count the ChangeLog as being substantive.
OK, great.
> >>> [...]
> >>> static const struct
> >>> {
> >>> const char *locale;
> >>> @@ -57,6 +62,14 @@ static const struct
> >>> { "pl_PL.UTF-8", "23 listopad 2017", "%d %B %Y", 4, 326, 10, 23 },
> >>> /* The nominative case is incorrect here but it is parseable. */
> >>> { "pl_PL.UTF-8", "24 listopad 2017", "%d %OB %Y", 5, 327, 10, 24 },
> >>> + { "pl_PL.UTF-8", "25 lis 2017", "%d %Ob %Y", 6, 328, 10, 25 },
> >>> + { "ru_RU.UTF-8", "26 " CYR_n CYR_o CYR_ya " 2017", "%d %b %Y",
> >>> + 0, 329, 10, 26 },
> >>
> >
> > Do I understand correctly, should I use lines like these?
> >
> > + /* ноя - pronounce: 'noya' - "Nov" (abbreviated "November") in Russian. */
> > + { "ru_RU.UTF-8", "26 ноя 2017", "%d %b %Y", 0, 329, 10, 26 },
>
> Yes, exactly like this.
OK, done locally.
Regards,
Rafal