This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v3 01/18] Parameterize op_t from memcopy.h

From: Joseph Myers <joseph at codesourcery dot com>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: <libc-alpha at sourceware dot org>, Richard Henderson <rth at twiddle dot net>
Date: Thu, 11 Jan 2018 13:27:52 +0000
Subject: Re: [PATCH v3 01/18] Parameterize op_t from memcopy.h
Authentication-results: sourceware.org; auth=none
References: <1515588482-15744-1-git-send-email-adhemerval.zanella@linaro.org> <1515588482-15744-2-git-send-email-adhemerval.zanella@linaro.org>

On Wed, 10 Jan 2018, Adhemerval Zanella wrote:

> +#ifdef _LONG_LONG_LIMB
> +typedef unsigned long long int __attribute__((__may_alias__)) op_t;
> +#else
> +typedef unsigned long int __attribute__((__may_alias__)) op_t;
> +#endif

Missing space between __attribute__ and '('.

> +#if defined __GMP_H__ && ! defined _LONG_LONG_LIMB
> +#error "Included too late for _LONG_LONG_LIMB to take effect"
> +#endif

Missing preprocessor indentation, "# error".

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH v3 01/18] Parameterize op_t from memcopy.h
  - From: Adhemerval Zanella

References:
- [PATCH v3 00/18] Improve generic string routines
  - From: Adhemerval Zanella
- [PATCH v3 01/18] Parameterize op_t from memcopy.h
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]