This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v11 1/5] Implement alternative month names (bug 10871).
On 01/08/2018 04:14 PM, Rafal Luzynski wrote:
> 9.01.2018 00:59 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
>> [...]
>> [BZ #10871]
>> * locale/C-time.c: Add alternative month names, define them as the
>> same as mon explicitly.
>> * locale/categories.def: alt_mon and wide-alt_mon added.
>> * locale/langinfo.h [__USE_GNU]: New public symbols ALTMON_1,
>> ALTMON_2, ALTMON_3, ALTMON_4, ALTMON_5, ALTMON_6, ALTMON_7,
>> ALTMON_8, ALTMON_9, ALTMON_10, ALTMON_11, ALTMON_12,
>> _NL_WALTMON_1, _NL_WALTMON_2, _NL_WALTMON_3, _NL_WALTMON_4,
>> _NL_WALTMON_5, _NL_WALTMON_6, _NL_WALTMON_7, _NL_WALTMON_8,
>> _NL_WALTMON_9, _NL_WALTMON_10, _NL_WALTMON_11, _NL_WALTMON_12.
>
> Carlos, what do you think about splitting this into:
>
> * locale/langinfo.h: New public symbols _NL_WALTMON_1,
> _NL_WALTMON_2, _NL_WALTMON_3, _NL_WALTMON_4, _NL_WALTMON_5,
> _NL_WALTMON_6, _NL_WALTMON_7, _NL_WALTMON_8, _NL_WALTMON_9,
> _NL_WALTMON_10, _NL_WALTMON_11, _NL_WALTMON_12.
> [__USE_GNU]: New public symbols ALTMON_1, ALTMON_2, ALTMON_3,
> ALTMON_4, ALTMON_5, ALTMON_6, ALTMON_7, ALTMON_8, ALTMON_9,
> ALTMON_10, ALTMON_11, ALTMON_12.
>
> or even:
>
> * locale/langinfo.h: New public symbols __ALTMON_1,
> __ALTMON_2, __ALTMON_3, __ALTMON_4, __ALTMON_5, __ALTMON_6,
> __ALTMON_7, __ALTMON_8, __ALTMON_9, __ALTMON_10, __ALTMON_11,
> __ALTMON_12, _NL_WALTMON_1, _NL_WALTMON_2, _NL_WALTMON_3,
> _NL_WALTMON_4, _NL_WALTMON_5, _NL_WALTMON_6, _NL_WALTMON_7,
> _NL_WALTMON_8, _NL_WALTMON_9, _NL_WALTMON_10, _NL_WALTMON_11,
> _NL_WALTMON_12.
> [__USE_GNU]: New public symbols ALTMON_1, ALTMON_2, ALTMON_3,
> ALTMON_4, ALTMON_5, ALTMON_6, ALTMON_7, ALTMON_8, ALTMON_9,
> ALTMON_10, ALTMON_11, ALTMON_12.
>
I think Dmitry has given a good suggestion here, and I would follow
what he recommends. The ChangeLog is a bit messy with complex macros
like this, and you have done a great job with it.
--
Cheers,
Carlos.