This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3 07/19] RISC-V: Build Infastructure
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Darius Rad <darius at bluespec dot com>
- Cc: Palmer Dabbelt <palmer at dabbelt dot com>, <libc-alpha at sourceware dot org>, <patches at groups dot riscv dot org>
- Date: Fri, 5 Jan 2018 13:44:55 +0000
- Subject: Re: [PATCH v3 07/19] RISC-V: Build Infastructure
- Authentication-results: sourceware.org; auth=none
- References: <20171227060534.3998-1-palmer@dabbelt.com> <20171227060534.3998-8-palmer@dabbelt.com> <alpine.DEB.2.20.1801011302230.23191@digraph.polyomino.org.uk> <a6719c35-0a7e-c7a5-7ea4-956b12d1137b@bluespec.com>
On Thu, 4 Jan 2018, Darius Rad wrote:
> > You don't need such long and redundant conditions. I'd expect something
> > simpler like on other architectures (e.g. !defined __LP64__ && defined
> > __riscv_float_abi_soft in this case - in general, just checking one macro
> > for the ILP32/LP64 distinction, one for the floating-point ABI).
> >
>
> I'll remove the extraneous checks for the floating point ABI. However,
> I think the other checks are necessary, as __LP64__/__ILP32__ are not
> defined by gcc when -mabi is used. That might be a gcc bug, but that
__LP64__ is defined in architecture-independent code (cppbuiltin.c), so
should be fully suitable for this. (__ILP32__ is indeed an
architecture-specific macro on only some architectures.)
--
Joseph S. Myers
joseph@codesourcery.com