This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/5] nptl: Add mutex-internal.h
On 01/01/2018 10:38, Adhemerval Zanella wrote:
>
>
> On 31/12/2017 23:38, Joseph Myers wrote:
>> On Fri, 29 Dec 2017, Adhemerval Zanella wrote:
>>
>>> Checked with a build on affected abis (alpha-linux-gnu, armv7-linux-gnueabihf,
>>> hppa-linux-gnu, ia64-linux-gnu, i686-linux-gnu, m68k-linux-gnu,
>>> microblaze-linux-gnu, nios2-linux-gnu, powerpc{64le}-linux-gnu,
>>> s390{x}-linux-gnu, sh4-linux-gnu, sparc{v9,64}-linux-gnu,
>>> tile{pro,gx64}-linux-gnu, x86_64-linux-gnu).
>>
>> Did you verify that installed stripped shared libraries are unchanged by
>> the patch for all those configurations? I think that's important
>> validation to do for a change such as this. (The same comment applies to
>> patch 2 as well.)
>>
>
> No, but I will do the verification. For mutex types I think the current
> static assert checks should be suffice to check for any ABI changes,
> while for rwlock I think we should add a static assert for the user
> visible flag field.
>
I checked the installed stripped shared libraries with and without the
patch I saw changes for ia64-linux-gnu, m68k-linux-gnu, i686-linux-gnu,
and mips64-linux-gnu. However they are introduced by the __pthread_list_t
and __pthread_slist_t declaration done regardless it will be used by
__pthread_mutex_s (previously they are only declared if the struct
actually used it). If I comment the unrequired one the resulted shared
libraries are unchanged and I think this change should be safe.