This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available
- From: Luke Shumaker <lukeshu at lukeshu dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: "Dmitry V. Levin" <ldv at altlinux dot org>, <libc-alpha at sourceware dot org>
- Date: Sun, 31 Dec 2017 21:28:50 -0500
- Subject: Re: [PATCH] tst-ttyname: skip the test when /dev/ptmx is not available
- Authentication-results: sourceware.org; auth=none
- References: <20171225114806.GB4341@altlinux.org> <87a7y6u0u7.fsf@mid.deneb.enyo.de> <20171225191256.GA8591@altlinux.org> <CAKCAbMinevgdXqj2-YKkVuJw_uhzOdYhfx7A_Q98fr=FVbB8TA@mail.gmail.com> <20171225210058.GA10404@altlinux.org> <874lodskm6.fsf@mid.deneb.enyo.de> <20171226135330.GA21089@altlinux.org> <20171226230703.GB28737@altlinux.org> <alpine.DEB.2.20.1801010127360.28505@digraph.polyomino.org.uk>
On Sun, 31 Dec 2017 20:30:16 -0500,
Joseph Myers wrote:
> On Wed, 27 Dec 2017, Dmitry V. Levin wrote:
>
> > > > > It's a restricted environment.
> > > >
> > > > I don't think the glibc test suite is supposed to pass in such an
> > > > environment.
> > >
> > > It used to work perfectly for at least 15 years, and it still works
> > > when tst-ttyname is fixed.
> >
> > As tst-ttyname was backported to 2.26 stable branch recently, it
> > introduced this test suite regression there, too, so a fix to tst-ttyname
> > should also be backported.
>
> I'm more concerned that we still have the failure on Ubuntu 16.04 noted in
> <https://sourceware.org/ml/libc-alpha/2017-11/msg00832.html>, than about
> failures in a particular restricted environment. Generally, if there are
> known unresolved issues around a patch on master, that's evidence it would
> be premature to backport it to a stable branch. (Note: I haven't actually
> verified if the failure on Ubuntu 16.04 is now present on the release
> branch.)
Yikes! I didn't notice that reply. I've just downloaded the Ubuntu
16.04.3 ISO and will look in to that in the next few days.
--
Happy hacking,
~ Luke Shumaker