This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/3] Cleanup __ieee754_sqrt(f/l)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Wed, 20 Dec 2017 18:07:34 +0000
- Subject: Re: [PATCH v2 1/3] Cleanup __ieee754_sqrt(f/l)
- Authentication-results: sourceware.org; auth=none
- References: <DB6PR0801MB20536A8C78D2B93DE2412C7E830C0@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On Wed, 20 Dec 2017, Wilco Dijkstra wrote:
> Build & test OK on AArch64.
I think the general design is right, but I also think this really needs a
build-many-glibcs.py test run (as do subsequent patches moving calls to
use sqrt/sqrtf/sqrtl directly) because of the high risk of
architecture-specific breakage.
(Direct calling of sqrtf128 with similar redirects to those for sqrt /
sqrtf / sqrtl is also appropriate: GCC 8 has it as a built-in function so
can inline calls with -fno-math-errno on powerpc64le for POWER9. So the
patch should include a sqrtf128 redirect if __HAVE_DISTINCT_FLOAT128.)
> diff --git a/math/w_sqrt_template.c b/math/w_sqrt_template.c
> index 5fae302382d10e9b05df2665c9cb05126cd62f02..235c263e60c85422e41bca7c817148b66030438f 100644
> --- a/math/w_sqrt_template.c
> +++ b/math/w_sqrt_template.c
> @@ -21,6 +21,7 @@
> for each floating-point type. */
> #if __USE_WRAPPER_TEMPLATE
>
> +#define NO_SQRT_REDIRECT
Missing preprocessor indentation, "# define".
--
Joseph S. Myers
joseph@codesourcery.com