This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 07/15] RISC-V: RV32F Support

From: Joseph Myers <joseph at codesourcery dot com>
To: Palmer Dabbelt <palmer at dabbelt dot com>
Cc: <libc-alpha at sourceware dot org>, Andrew Waterman <andrew at sifive dot com>, Darius Rad <darius at bluespec dot com>, <dj at redhat dot com>
Date: Wed, 20 Dec 2017 17:04:04 +0000
Subject: Re: [PATCH v2 07/15] RISC-V: RV32F Support
Authentication-results: sourceware.org; auth=none
References: <20171220072022.26909-1-palmer@dabbelt.com> <20171220072022.26909-8-palmer@dabbelt.com> <alpine.DEB.2.20.1712201658080.30469@digraph.polyomino.org.uk>

On Wed, 20 Dec 2017, Joseph Myers wrote:

> On Tue, 19 Dec 2017, Palmer Dabbelt wrote:
> 
> > +  int nan = isnanf (x);
> 
> I don't think any libm code should be using the legacy X/Open 
> type-specific classification functions such as isnanf.  Use the C99 
> type-generic macros such as isnan instead.

Also, and again in patch 8: I think new code should preferably use bool 
(from <stdbool.h>) for boolean variables like this, instead of int.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH v2 07/15] RISC-V: RV32F Support
  - From: Palmer Dabbelt

References:
- RISC-V glibc port v2
  - From: Palmer Dabbelt
- [PATCH v2 07/15] RISC-V: RV32F Support
  - From: Palmer Dabbelt
- Re: [PATCH v2 07/15] RISC-V: RV32F Support
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]