This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 04/15] RISC-V: Thread-Local Storage Support
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Palmer Dabbelt <palmer at dabbelt dot com>
- Cc: <libc-alpha at sourceware dot org>, Andrew Waterman <andrew at sifive dot com>, Darius Rad <darius at bluespec dot com>, <dj at redhat dot com>
- Date: Wed, 20 Dec 2017 16:45:46 +0000
- Subject: Re: [PATCH v2 04/15] RISC-V: Thread-Local Storage Support
- Authentication-results: sourceware.org; auth=none
- References: <20171220072022.26909-1-palmer@dabbelt.com> <20171220072022.26909-5-palmer@dabbelt.com>
On Tue, 19 Dec 2017, Palmer Dabbelt wrote:
> +#define thread_offsetof(mem) (long)(offsetof(struct pthread, mem) - TLS_TCB_OFFSET - TLS_PRE_TCB_SIZE)
Missing space between offsetof and '('.
> +register void* __thread_self asm("tp");
Missing space after asm. Also should be "void *__thread_self" not "void*
__thread_self".
--
Joseph S. Myers
joseph@codesourcery.com