This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 03/15] RISC-V: Startup and Dynamic Loading Code
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Palmer Dabbelt <palmer at dabbelt dot com>
- Cc: <libc-alpha at sourceware dot org>, Andrew Waterman <andrew at sifive dot com>, Darius Rad <darius at bluespec dot com>, <dj at redhat dot com>
- Date: Wed, 20 Dec 2017 16:38:48 +0000
- Subject: Re: [PATCH v2 03/15] RISC-V: Startup and Dynamic Loading Code
- Authentication-results: sourceware.org; auth=none
- References: <20171220072022.26909-1-palmer@dabbelt.com> <20171220072022.26909-4-palmer@dabbelt.com>
On Tue, 19 Dec 2017, Palmer Dabbelt wrote:
> +extern ElfW(Addr) la_riscv_gnu_pltenter (ElfW(Sym) *__sym, unsigned int __ndx,
With reference to my previous comments, ElfW is an exception to the rule
of spaces before '(' in macro and function calls, because it locally
expands to a single identifier. So this code is correct not to have a
space there.
> + extern ElfW(Addr) _GLOBAL_OFFSET_TABLE_ __attribute__((visibility("hidden")));
However, __attribute__ is *not* an exception. This should use:
__attribute__ ((visibility ("hidden"))) - and likewise for other
attributes, elsewhere in this patch or the patch series as a whole.
General question in the area of this patch: static PIE support was
recently added to glibc. Do you support it for RISC-V? It's not so far a
requirement for adding a port, but if not supported, when the port goes in
it would need adding to the list at
<https://sourceware.org/glibc/wiki/PortStatus> of ports for which static
PIE is not yet known to work.
--
Joseph S. Myers
joseph@codesourcery.com