This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp

From: Joseph Myers <joseph at codesourcery dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Zack Weinberg <zackw at panix dot com>, Yu-cheng Yu <yu-cheng dot yu at intel dot com>, "Tsimbalist, Igor V" <igor dot v dot tsimbalist at intel dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Tue, 19 Dec 2017 18:33:35 +0000
Subject: Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp
Authentication-results: sourceware.org; auth=none
References: <20171218162753.GA25026@gmail.com> <alpine.DEB.2.20.1712181741480.26421@digraph.polyomino.org.uk> <CAMe9rOr3gEyaJZ7ukNTY=MiSdWnPbmLOqduodyk3Mx8Qn9J58w@mail.gmail.com> <CAMe9rOoMeYy21NHeL=H+gz2q=KTTPQ4ZwCNX+aP_uuy5ZDinqw@mail.gmail.com> <alpine.DEB.2.20.1712181819250.26421@digraph.polyomino.org.uk> <CAMe9rOqK_rD8SYo6aV_22tZohDpgUi_4shFH9763hG69BHDpEg@mail.gmail.com> <CAMe9rOp3MLhFeD9kU_Vav2=QSzQXrkKb_sXe68jCdGCwfDuFHw@mail.gmail.com> <CAKCAbMjwWOMcmksqwfrZt_m3xdJ_Si5BZCqnc-oAE32ye0_bkg@mail.gmail.com> <CAMe9rOo4newGKqhhRPc=p6N1M+JoQRa2=KbJBHv4yMyuFxp=CQ@mail.gmail.com>

On Tue, 19 Dec 2017, H.J. Lu wrote:

> > I don't think you have consensus. You haven't answered most of
> > Joseph's questions, and it is not clear to me whether Florian
> > considers his objection resolved.  This is not a high-priority bugfix.
> 
> I have answered all questions.   Please show one question which I haven't
> answered.

I don't think you've adequately justified having OS-specific versions of 
all the setjmp/longjmp files, as opposed to having e.g. defined __SHSTK__ 
&& defined SHADOW_STACK_POINTER_OFFSET && defined FEATURE_1_OFFSET 
conditionals in the OS-independent files (which looks more like the actual 
condition that should be relevant here).

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp
  - From: H.J. Lu

References:
- [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp
  - From: H.J. Lu
- Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp
  - From: Joseph Myers
- Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp
  - From: H.J. Lu
- Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp
  - From: Joseph Myers
- Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp
  - From: H.J. Lu
- Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp
  - From: H.J. Lu
- Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp
  - From: Zack Weinberg
- Re: [PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]