This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [hurd,commited] hurd: Fix rtld link
- From: Samuel Thibault <samuel dot thibault at ens-lyon dot org>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 15 Dec 2017 17:48:42 +0100
- Subject: Re: [hurd,commited] hurd: Fix rtld link
- Authentication-results: sourceware.org; auth=none
- References: <20170903023345.24804-1-samuel.thibault@ens-lyon.org> <876098j7ij.fsf@euler.schwinge.homeip.net>
Thomas Schwinge, on ven. 15 déc. 2017 17:11:32 +0100, wrote:
> Hi Samuel!
>
> On Sun, 3 Sep 2017 04:33:45 +0200, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> > --- a/sysdeps/mach/hurd/dl-sysdep.c
> > +++ b/sysdeps/mach/hurd/dl-sysdep.c
>
> > +int weak_function
> > +__access_noerrno (const char *file, int type)
> > +{
> > + errno = ENOSYS;
> > + return -1;
> > +}
D'oh...
> I just stumbled across this -- OK to push the following? Note that I
> have not tested this. If approving this, please respond with
> "Reviewed-by: NAME <EMAIL>" so that your effort will be recorded. See
> <https://gcc.gnu.org/wiki/Reviewed-by>.
>
> commit 336e16f8e6a588ba048997722a114f9d4462dbdb
> Author: Thomas Schwinge <thomas@codesourcery.com>
> Date: Fri Dec 15 17:00:50 2017 +0100
>
> Don't set errno in Hurd rtld's __access_noerrno
>
> * sysdeps/mach/hurd/dl-sysdep.c (__access_noerrno): Don't set
> errno.
>
> Fixes commit 819ea3347e3a30a611488ceeec53650baaeb7961.
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Thanks!
> ---
> sysdeps/mach/hurd/dl-sysdep.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git sysdeps/mach/hurd/dl-sysdep.c sysdeps/mach/hurd/dl-sysdep.c
> index 2cc342ec8e..5121ce325c 100644
> --- sysdeps/mach/hurd/dl-sysdep.c
> +++ sysdeps/mach/hurd/dl-sysdep.c
> @@ -575,7 +575,6 @@ check_no_hidden(__access_noerrno);
> int weak_function
> __access_noerrno (const char *file, int type)
> {
> - errno = ENOSYS;
> return -1;
> }
>
>
>
> Grüße
> Thomas
>