This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] elf: Count components of the expanded path in _dl_init_path [BZ #22607]
On Dez 14 2017, Florian Weimer <fweimer@redhat.com> wrote:
> On 12/14/2017 02:58 PM, Andreas Schwab wrote:
>> On Dez 14 2017, Florian Weimer <fweimer@redhat.com> wrote:
>>
>>> On 12/14/2017 02:45 PM, Andreas Schwab wrote:
>>>> On Dez 14 2017, fweimer@redhat.com (Florian Weimer) wrote:
>>>>
>>>>> + {
>>>>> + const char *cp = llp_tmp;
>>>>> + while (*cp)
>>>>> + {
>>>>> + if (*cp == ':' || *cp == ';')
>>>>> + ++nllp;
>>>>> + ++cp;
>>>>> + }
>>>>> + }
>>>>
>>>> No need for the outermost braces.
>>>
>>> I included them to limit the scope of cp, to make sure that there aren't
>>> any uses afterwards because of the changed value of cp compared to the
>>> original code.
>>
>> Since it is obviously unused afterwards I don't see any value for that.
>
> What about this? It follows Dmitry's suggestion to use a for loop.
Ok.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."