This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] x86-64: Add sinf with FMA
On 05/12/2017 17:03, H.J. Lu wrote:
> diff --git a/sysdeps/x86_64/fpu/multiarch/s_sinf.c b/sysdeps/x86_64/fpu/multiarch/s_sinf.c
> new file mode 100644
> index 0000000000..f91f866cdc
> --- /dev/null
> +++ b/sysdeps/x86_64/fpu/multiarch/s_sinf.c
> @@ -0,0 +1,31 @@
> +/* Multiple versions of sinf.
> + Copyright (C) 2017 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <libm-alias-float.h>
> +
> +extern float __redirect_sinf (float);
> +
> +#define SYMBOL_NAME sinf
> +#include "ifunc-fma.h"
> +
> +libc_ifunc_redirected (__redirect_sinf, __sinf, IFUNC_SELECTOR ());
> +
> +libm_alias_float (__sin, sin)
> +
> +#define SINF __sinf_sse2
> +#include <sysdeps/ieee754/flt-32/s_sinf.c>
> -- 2.14.3
I would prefer if we move the default version to specific files instead
of incorporate them on ifunc resolver itself. In this case add a
sysdeps/x86_64/fpu/multiarch/s_sinf-sse2.c file with:
#define SINF __sinf_sse2
#include <sysdeps/ieee754/flt-32/s_sinf.c>
LGTM with this change.