This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PING][PATCH] aarch64: Avoid hidden symbols for memcpy/memmove into static binaries
- From: Siddhesh Poyarekar <siddhesh at sourceware dot org>
- To: libc-alpha at sourceware dot org
- Date: Mon, 4 Dec 2017 18:14:28 +0530
- Subject: [PING][PATCH] aarch64: Avoid hidden symbols for memcpy/memmove into static binaries
- Authentication-results: sourceware.org; auth=none
- References: <1512041196-14726-1-git-send-email-siddhesh@sourceware.org>
- Reply-to: siddhesh at sourceware dot org
Ping?
On Thursday 30 November 2017 04:56 PM, Siddhesh Poyarekar wrote:
> The __GI_* symbol aliases for __memcpy_generic are unnecessary since
> they're never used. Add them only for libc.so to avoid PLT.
>
> * sysdeps/aarch64/multiarch/memcpy_generic.S (__GI_memcpy):
> Define only for libc.so.
> ---
> sysdeps/aarch64/multiarch/memcpy_generic.S | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sysdeps/aarch64/multiarch/memcpy_generic.S b/sysdeps/aarch64/multiarch/memcpy_generic.S
> index 041a779..edb2e52 100644
> --- a/sysdeps/aarch64/multiarch/memcpy_generic.S
> +++ b/sysdeps/aarch64/multiarch/memcpy_generic.S
> @@ -33,9 +33,11 @@
> # undef libc_hidden_builtin_def
> # define libc_hidden_builtin_def(name)
>
> +# ifdef SHARED
> /* It doesn't make sense to send libc-internal memcpy calls through a PLT. */
> .globl __GI_memcpy; __GI_memcpy = __memcpy_generic
> .globl __GI_memmove; __GI_memmove = __memmove_generic
> +# endif
>
> #endif
>
>