This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] cs_CZ locale: fix collation [BZ #22336]
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Mike FABIAN <mfabian at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 27 Nov 2017 09:30:51 -0800
- Subject: Re: [PATCH] cs_CZ locale: fix collation [BZ #22336]
- Authentication-results: sourceware.org; auth=none
- References: <s9d609w2pms.fsf@taka.site>
On 11/26/2017 10:37 PM, Mike FABIAN wrote:
>
> [BZ #22336]
> * localedata/locales/cs_CZ (LC_COLLATE): Use “copy "iso14651_t1"”
> and implement the collation rules for cs from CLDR on top of that.
> * Makefile: Add cs_CZ.UTF-8 to test-input and to the list
> of locales to be built for testing.
> * cs_CZ.UTF-8.in: New file with test data to test the Czech sorting.
>
> Difference in sorting of the added test file (added in the patch)
> before and after applying the sorting changes of the patch:
>
> [... deleted because this may have caused my mail to be caught by
> the spam filter because of the non-ASCII characters ...]
>
> See
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=22336#c1
>
> for the difference in sorting.
>
This looks good to me. Thanks for the new test file!
As the subsystem maintainer you can just commit these, unless you're looking
for further review. Overall it's hard for me to judge what's right here, but
the filed bugs are what's important to users.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.